Skip to content

ensure the latest tag is always used to determine version#867

Merged
jameslamb merged 2 commits intomainfrom
fix/tag-search
Mar 31, 2026
Merged

ensure the latest tag is always used to determine version#867
jameslamb merged 2 commits intomainfrom
fix/tag-search

Conversation

@jameslamb
Copy link
Copy Markdown
Member

@jameslamb jameslamb commented Mar 30, 2026

Nightly builds on main are failing like this:

56.98 Could not solve for environment specs
56.98 The following packages are incompatible
56.98 ├─ rapids-dask-dependency =26.6,>=0.0.0a0 * is requested and can be installed;
56.98 └─ rapids =26.4 * is not installable because it requires
56.98    └─ custreamz =26.4 *, which requires
56.98       └─ rapids-dask-dependency =26.4 *, which conflicts with any installable versions previously reported.

(build link)

They should be looking for 26.06 packages, and I'd expect them to because the v26.06.00a tag is closer to HEAD of main than v26.04.00a.

image

I think the root cause is that I made some mistake in creating the branch for #866 (still not sure exactly what) that ended up making v26.04.00a satisfy this:

docker/.github/workflows/build-cuvs-image.yml

Line 63 in 2637556

GIT_DESCRIBE_TAG="$(git describe --tags --abbrev=0)"

This proposes permanently avoiding by using git describe --first-parent

From https://git-scm.com/docs/git-describe

Follow only the first parent commit upon seeing a merge commit. This is useful when you wish to not match tags on branches merged in the history of the target commit.

Notes for Reviewers

How I tested this

$ git checkout main
$ git pull upstream main
$ git fetch upstream --tags
$ git describe --tags --abbrev=0
v26.04.00a
$ git describe --tags --first-parent --abbrev=0
v26.06.00a

@jameslamb jameslamb added bug Something isn't working non-breaking labels Mar 30, 2026
@jameslamb
Copy link
Copy Markdown
Member Author

jameslamb commented Mar 30, 2026

Yeah this is working, seeing RAPIDS_VER=26.06 in CI logs.

When this is approved, let's admin-merge past the failing check-nightly-ci check. This should fix the nightly builds.

@jameslamb jameslamb changed the title WIP: ensure the latest tag is always used to determine version ensure the latest tag is always used to determine version Mar 30, 2026
@jameslamb jameslamb marked this pull request as ready for review March 30, 2026 22:10
@jameslamb jameslamb requested a review from a team as a code owner March 30, 2026 22:10
@jameslamb jameslamb requested review from AyodeAwe and bdice and removed request for bdice March 30, 2026 22:10
@jameslamb
Copy link
Copy Markdown
Member Author

jameslamb commented Mar 31, 2026

Tests are failing like this:

ImportError: /opt/conda/bin/../lib/libcugraph_mg.so: undefined symbol: _ZN3rmm13device_bufferC1EmNS_16cuda_stream_viewENS_6detail23cccl_async_resource_refIN4cuda2mr3__412resource_refIJNS6_17device_accessibleEEEEEE

(build link)

That'll be fixed by a new build of cuGraph, once rapidsai/cugraph#5479 is in

@jameslamb
Copy link
Copy Markdown
Member Author

jameslamb commented Mar 31, 2026

Pushed an empty commit to trigger a new build, now that package builds (esp. for cuGraph) should be fixed.

@jameslamb
Copy link
Copy Markdown
Member Author

jameslamb commented Mar 31, 2026

Everything but check-nightly-ci is now passing, admin-merging this. That should fix the nightly builds and get check-nightly-ci passing again.

@jameslamb jameslamb merged commit 6f44eb9 into main Mar 31, 2026
62 of 64 checks passed
@jameslamb jameslamb deleted the fix/tag-search branch March 31, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AyodeAwe AyodeAwe AyodeAwe approved these changes

Assignees

No one assigned

Labels

bug Something isn't working non-breaking

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jameslamb @AyodeAwe